Fix duplicate baggage headers in Celery integration introduced in SDK 2.0#2993
Merged
Conversation
antonpirker
changed the title
sentrivana
approved these changes
Apr 22, 2024
sentrivana
left a comment
sentrivana
left a comment
Contributor
There was a problem hiding this comment.
see comment, else lgtm!
Co-authored-by: Ivana Kellyerova <ivana.kellyerova@sentry.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the accumulating baggage headers when dogfooding SDK 2.0 on
sentry.io.This reverts the refactoring of header manipulation that was added in
rc4back to what is present in currentmaster.This PR uses the working code from
master(that is also inrc3) and then extracts the header manipulating code into_update_celery_task_headers()to make it more readable and also testable.This PR adds a couple of tests to make sure we do not change the behavior by accident in the future.
(This does not fix #2916 but it uncovered the root cause. The fix is in a follow up PR: #3001)