feat(scope): New set_tags function#2978
Merged
Merged
Conversation
Contributor
|
@szokeasaurusrex Please add the tests and the top-level API to this PR -- it all belongs together and should be reviewed together. |
szokeasaurusrex
marked this pull request as draft
April 15, 2024 11:35
szokeasaurusrex
commented
Apr 15, 2024
szokeasaurusrex
marked this pull request as ready for review
April 15, 2024 12:02
Member
Author
@sentrivana, done! |
sentrivana
approved these changes
Apr 15, 2024
sentrivana
left a comment
sentrivana
left a comment
Contributor
There was a problem hiding this comment.
👍🏻
Please also update https://docs.sentry.io/platforms/python/enriching-events/tags/ and potentially other places in the docs where it makes sense.
szokeasaurusrex
added a commit
to getsentry/sentry-docs
that referenced
this pull request
Apr 15, 2024
Add documentation for the [new `set_tags` function](getsentry/sentry-python#2978) in the Python SDK. Closes GH-9703
3 tasks
szokeasaurusrex
added a commit
to getsentry/sentry-docs
that referenced
this pull request
Apr 16, 2024
Add documentation for the [new `set_tags` function](getsentry/sentry-python#2978) in the Python SDK. Closes GH-9703
`Scope.set_tags` allows multiple tags to be set at the same time by passing the tags to update as a dictionary (or other `Mapping` type). Closes GH-1344
Co-authored-by: Ivana Kellyerova <ivana.kellyerova@sentry.io>
szokeasaurusrex
force-pushed
the
szokeasaurusrex/set-tags
branch
from
April 26, 2024 10:26
85f4bbc to
ab11fb7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope.set_tagsallows multiple tags to be set at the same time by passing the tags to update as a dictionary (or otherMappingtype).Closes GH-1344