Skip to content

[2.0] Remove unicode literals#2642

Merged
sentrivana merged 2 commits into
sentry-sdk-2.0from
ivana/py2.7/remove-u-strings
Jan 16, 2024
Merged

[2.0] Remove unicode literals#2642
sentrivana merged 2 commits into
sentry-sdk-2.0from
ivana/py2.7/remove-u-strings

Conversation

@sentrivana

Copy link
Copy Markdown
Contributor
  • remove Python 2.7 u"unicode literals"
  • remove fmt: off used for keeping unicode literals intact

General Notes

Thank you for contributing to sentry-python!

Please add tests to validate your changes, and lint your code using tox -e linters.

Running the test suite on your PR might require maintainer approval. Some tests (AWS Lambda) additionally require a maintainer to add a special label to run and will fail if the label is not present.

For maintainers

Sensitive test suites require maintainer review to ensure that tests do not compromise our secrets. This review must be repeated after any code revisions.

Before running sensitive test suites, please carefully check the PR. Then, apply the Trigger: tests using secrets label. The label will be removed after any code changes to enforce our policy requiring maintainers to review all code revisions before running sensitive tests.

@szokeasaurusrex szokeasaurusrex left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@sentrivana
sentrivana merged commit ec5b85a into sentry-sdk-2.0 Jan 16, 2024
@sentrivana
sentrivana deleted the ivana/py2.7/remove-u-strings branch January 16, 2024 11:33
@sentrivana sentrivana self-assigned this Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants