[2.0] Drop Python 2.7, 3.5 from CI (1)#2640
Conversation
- remove special treatment for Python 2.7 from CI YAML generating - remove Python 2.7, 3.5 test environments from tox.ini
sentrivana
changed the title
szokeasaurusrex
left a comment
szokeasaurusrex
left a comment
There was a problem hiding this comment.
I have a couple questions, please see inline comments
| fail-fast: false | ||
| matrix: | ||
| python-version: ["3.5","3.8","3.11","3.12"] | ||
| python-version: ["3.8","3.11","3.12"] |
There was a problem hiding this comment.
Should we be testing 3.6 and/or 3.7 here?
There was a problem hiding this comment.
We should -- the yaml files will be updated as soon as I add these to tox.ini
| # Bottle | ||
| {py2.7,py3.5,py3.9}-bottle-v{0.12} | ||
| {py3.5,py3.11,py3.12}-bottle-latest | ||
| {py3.9}-bottle-v{0.12} |
There was a problem hiding this comment.
Do we need py 3.6 here (or in any of the other tests where py3.5 was removed)?
There was a problem hiding this comment.
This is a very good point, adding this!
|
Added |
szokeasaurusrex
left a comment
szokeasaurusrex
left a comment
There was a problem hiding this comment.
I added inline comments in a few spots where it is possible that we should be adding 3.6, but I am unsure. Please double check these locations, and fix them if necessary – then I think this is good to merge!
|
|
||
| # pure_eval | ||
| {py3.5,py3.11,py3.12}-pure_eval | ||
| {py3.11,py3.12}-pure_eval |
There was a problem hiding this comment.
Missed this one, will add
There was a problem hiding this comment.
Changed to {py3.6,py3.11,py3.12}-pure_eval
|
|
||
| # Redis | ||
| {py2.7,py3.7,py3.8}-redis-v{3} | ||
| {py3.7,py3.8}-redis-v{3} |
There was a problem hiding this comment.
Changed to {py3.6,py3.8}-redis-v{3} (dropped 3.7, no need to check against every single supported py version, going with lowest-highest supported)
|
|
||
| # Redis Cluster | ||
| {py2.7,py3.7,py3.8}-rediscluster-v{1,2} | ||
| {py3.7,py3.8}-rediscluster-v{1,2} |
There was a problem hiding this comment.
Changed to {py3.6,py3.8}-rediscluster-v{1,2} (same reasoning as above)
|
|
||
| # Requests | ||
| {py2.7,py3.8,py3.11,py3.12}-requests | ||
| {py3.8,py3.11,py3.12}-requests |
There was a problem hiding this comment.
👍🏻 {py3.6,py3.8,py3.11,py3.12}-requests
|
|
||
| # SQL Alchemy | ||
| {py2.7,py3.7,py3.9}-sqlalchemy-v{1.2,1.4} | ||
| {py3.7,py3.9}-sqlalchemy-v{1.2,1.4} |
There was a problem hiding this comment.
Changed to {py3.6,py3.9}-sqlalchemy-v{1.2,1.4}
|
Thanks for the thorough review @szokeasaurusrex! 👍🏻 |
2 participants
tox.iniGeneral Notes
Thank you for contributing to
sentry-python!Please add tests to validate your changes, and lint your code using
tox -e linters.Running the test suite on your PR might require maintainer approval. Some tests (AWS Lambda) additionally require a maintainer to add a special label to run and will fail if the label is not present.
For maintainers
Sensitive test suites require maintainer review to ensure that tests do not compromise our secrets. This review must be repeated after any code revisions.
Before running sensitive test suites, please carefully check the PR. Then, apply the
Trigger: tests using secretslabel. The label will be removed after any code changes to enforce our policy requiring maintainers to review all code revisions before running sensitive tests.