Skip to content

Pin pytest-asyncio to <=0.21 - #2563

Merged
sentrivana merged 4 commits into
masterfrom
ivana/fix-failing-tests
Dec 4, 2023
Merged

sentrivana merged 4 commits into
masterfrom
ivana/fix-failing-tests

Conversation

@sentrivana

Copy link
Copy Markdown
Collaborator

Seems like the recent release of pytest-asyncio 0.23 might have broken some of our tests -- validating that assumption.

@antonpirker

Copy link
Copy Markdown
Contributor

I think it is not pytest-asyncio (those are the changes for latest release: https://github.com/pytest-dev/pytest-asyncio/pull/704/files) but some sub-dependency

@sentrivana sentrivana changed the title Pin pytest-asyncio Pin pytest-asyncio to <=0.21 Dec 4, 2023
@sentrivana

sentrivana commented Dec 4, 2023 •

Copy link
Copy Markdown
Collaborator Author

I think it is not pytest-asyncio (those are the changes for latest release: https://github.com/pytest-dev/pytest-asyncio/pull/704/files) but some sub-dependency

It still could be, I think we were going from 0.21.1 to 0.23.* and there was a lot happening between 0.21 and 0.23: pytest-dev/pytest-asyncio@v0.21.1...v0.23.0

@sentrivana

Copy link
Copy Markdown
Collaborator Author

Looks like adding an upper bound to pytest-asyncio fixes it -- I'd merge this for now to unblock other PRs and then investigate further if it can be narrowed down to a dependency of pytest-asyncio.

@sentrivana
sentrivana marked this pull request as ready for review December 4, 2023 15:04
@sentrivana
sentrivana merged commit 99c3849 into master Dec 4, 2023
@sentrivana
sentrivana deleted the ivana/fix-failing-tests branch December 4, 2023 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants