Hash AWS Lambda test functions based on current revision#2557
Merged
Conversation
|
@antonpirker I'm guessing regarding this, we now get these errors in Sentry UI, if we're deploying our staging code for testing / demo purposes (At least - Have not tested with real production code with a bit different conf). These deploy's send errors to sentry, but do not have
|
Contributor
Author
|
Hey @HansAarneLiblik, fixing that in: #2591 |
Contributor
Author
|
@HansAarneLiblik SDK version 1.39.1 that should fix this is now available -- thanks for reporting! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We were using the current SDK version for determining whether an AWS Lambda function should be reused, so e.g. on PRs, this would reuse the existing functions instead of creating new ones with any changes from the PR. Changing this to use the current commit instead.
Also, use a 6 character hash instead of 5 characters, just to lower the chance for collisions a bit.