Repository navigation
Add a pull request template - #2549
Merged
Merged
Conversation
szokeasaurusrex
approved these changes
Dec 4, 2023
szokeasaurusrex
left a comment
szokeasaurusrex
left a comment
Member
There was a problem hiding this comment.
Looks good to me as is. I added some suggestions for how we could improve the wording; please feel free to accept or reject these suggestions as you see fit
Co-authored-by: Daniel Szoke <szokeasaurusrex@users.noreply.github.com>
Collaborator
Author
|
Thanks @szokeasaurusrex! Applied your suggestions. |
Co-authored-by: Daniel Szoke <szokeasaurusrex@users.noreply.github.com>
sentrivana
enabled auto-merge (squash)
December 6, 2023 13:09
auto-merge was automatically disabled
December 6, 2023 13:13
Pull Request is not mergeable
sentrivana
enabled auto-merge (squash)
December 6, 2023 13:15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since we've changed our PR workflow with the addition of the
Trigger: tests using secretslabel, let's persist this info somewhere for both external contributors and folks maintaining the repo.