Repository navigation
Skip permissions step on push events - #2548
Merged
Merged
Conversation
antonpirker
approved these changes
Nov 30, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The AWS Lambda test suite is failing on master. It runs a script to check whether a PR author has the right permissions to run the test suite, but the event that triggers the workflow is not a PR being opened/updated, but rather pushing to a repo branch.
In the patch here we treat the two possible event types differently:
push, we skip the permissions check entirely since thepushevent is only emitted on changes to repo branches (and we only limit it tomasterandrelease/branches), which can only be triggered by people with write permissionspull_request_target, we run the permissions check as before