Repository navigation
Do not create a span when task is triggered by Celery Beat - #2510
Merged
Merged
Conversation
…entry/sentry-python into antonpirker/parent-span-celery-beat
antonpirker
marked this pull request as ready for review
November 15, 2023 13:46
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We create a span for submitting a Celery task for execution (when
apply_async()is called). In cases where web frameworks are callingapply_async()this is fine, because the web framework created a transaction where the span is attached.When Celery Beat wakes up and is calling
apply_async()this is not good, because there is no transaction and then the span ID of the newly created span will be given to the task asparent_span_idleading to orphaned transactions.So in case
apply_async()is called by Celery Beat, we do not create a span for submitting the task for execution.Fixes #1096