fix: Implement repr hooks, refactor cycle breaking#247
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #247 +/- ##
==========================================
+ Coverage 81.62% 81.71% +0.08%
==========================================
Files 32 32
Lines 2732 2745 +13
Branches 443 443
==========================================
+ Hits 2230 2243 +13
Misses 340 340
Partials 162 162
Continue to review full report at Codecov.
|
HazAT
reviewed
Jan 30, 2019
Contributor
|
This will mean tons of tls accesses though. That seems suboptimal. |
Member
Author
|
@mitsuhiko I think the most recent commit fixes things. I don't think we need to figure out a general solution for avoiding too many TLS accesses. I assume external users will just unconditionally run their logic anyway |
untitaker
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.