Repository navigation
Make debug option also configurable via environment - #2450
Merged
Merged
Conversation
antonpirker
changed the title
debug option also configurable via environment
sentrivana
reviewed
Oct 16, 2023
Comment on lines
+113
to
+117
| rv["debug"] = os.environ.get("SENTRY_DEBUG", "False").lower() in ( | ||
| "true", | ||
| "1", | ||
| "t", | ||
| ) |
Collaborator
There was a problem hiding this comment.
I kinda remember that we added a helper for determining if a config option was set to something truthy. Can't find it off the top of my head but will look a bit more 👀
sentrivana
approved these changes
Oct 16, 2023
sentrivana
left a comment
sentrivana
left a comment
Collaborator
There was a problem hiding this comment.
Can't find the util function. 🤷🏻♀️ LGTM.
Contributor
Author
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introducing new
SENTRY_DEBUGenvironment variable that can be used to set thedebugoption insentry_sdk.init().