Skip to content

RQ changed how the set jobs to failed. Dealing with this. #2405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
antonpirker merged 2 commits into from
Oct 4, 2023
Merged

RQ changed how the set jobs to failed. Dealing with this. #2405

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4b2fa94
RQ changed how the set jobs to failed. Dealing with this.
antonpirker Oct 2, 2023
68c2caa
Merge branch 'master' into antonpirker/make-sdk-work-with-new-rq-release
antonpirker Oct 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion sentry_sdk/integrations/rq.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
from rq.timeouts import JobTimeoutException
from rq.version import VERSION as RQ_VERSION
from rq.worker import Worker
from rq.job import JobStatus
except ImportError:
raise DidNotEnable("RQ not installed")

Expand Down Expand Up @@ -95,7 +96,9 @@ def sentry_patched_perform_job(self, job, *args, **kwargs):

def sentry_patched_handle_exception(self, job, *exc_info, **kwargs):
# type: (Worker, Any, *Any, **Any) -> Any
if job.is_failed:
# Note, the order of the `or` here is important,
# because calling `job.is_failed` will change `_status`.
if job._status == JobStatus.FAILED or job.is_failed:
_capture_exception(exc_info) # type: ignore

return old_handle_exception(self, job, *exc_info, **kwargs)
Expand Down