Connection attributes in redis database spans#2398
Merged
antonpirker merged 19 commits intoOct 11, 2023
Merged
Conversation
antonpirker
force-pushed
the
antonpirker/2270-db-connection-attributes-in-spans-redis
branch
from
September 29, 2023 08:14
1541f9c to
3550016
Compare
antonpirker
marked this pull request as ready for review
September 29, 2023 08:15
antonpirker
enabled auto-merge (squash)
October 4, 2023 09:35
antonpirker
deleted the
antonpirker/2270-db-connection-attributes-in-spans-redis
branch
October 11, 2023 11:20
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds db connection parameters like database host, database port, database name, database system ("redis" in this case) to all database spans that are created by our Redis integration. Works for async and sync connections to redis and redis cluster.
Needed for project Starfish.
fixes #2390