Handle iteration errors during frame traversal#239
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #239 +/- ##
=========================================
- Coverage 81.28% 80.5% -0.78%
=========================================
Files 32 32
Lines 2703 2703
Branches 440 440
=========================================
- Hits 2197 2176 -21
- Misses 343 366 +23
+ Partials 163 161 -2
Continue to review full report at Codecov.
|
Member
|
I believe it would be appropriate to only traverse builtin collections (check for |
Member
|
Cool, could you add an explanatory comment as well? |
Contributor
Author
|
@untitaker Do you mean comment to code or commit message? |
Member
|
in the code :) thanks! |
Member
|
Awesome thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #238
Not sure if this is the best way to show it, i think it is better than showing just empty list. But maybe there could be some better way to show that exception occured during traversal.
There is more general problem that it is probably good to not iterate over queryset, so DB is not queried. Any ideas on how to do that?