Skip to content

Prevent Falcon integration from breaking ASGI apps#2359

Merged
szokeasaurusrex merged 7 commits into
masterfrom
szokeasaurusrex/falcon-fix-second-attempt
Sep 12, 2023
Merged

Prevent Falcon integration from breaking ASGI apps#2359
szokeasaurusrex merged 7 commits into
masterfrom
szokeasaurusrex/falcon-fix-second-attempt

Conversation

@szokeasaurusrex

Copy link
Copy Markdown
Member

Fixes #1946 and supersedes #2346

@szokeasaurusrex
szokeasaurusrex enabled auto-merge (squash) September 8, 2023 12:37
Comment thread sentry_sdk/integrations/falcon.py

@antonpirker antonpirker left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@szokeasaurusrex
szokeasaurusrex merged commit 90c64ca into master Sep 12, 2023
@szokeasaurusrex
szokeasaurusrex deleted the szokeasaurusrex/falcon-fix-second-attempt branch September 12, 2023 09:14
sentrivana pushed a commit that referenced this pull request Sep 18, 2023
* Prevent Falcon integration from breaking ASGI apps

* Remove trailing comma
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

sentry-sdk stopped working with falcon 3+ asgi app

2 participants