Documenting Spans and Transactions#2358
Merged
Merged
Conversation
sentrivana
approved these changes
Sep 7, 2023
sentrivana
left a comment
sentrivana
left a comment
Contributor
There was a problem hiding this comment.
This is so nice!
Left some typo/grammar/prettifying suggestions.
Co-authored-by: Ivana Kellyerova <ivana.kellyerova@sentry.io>
Co-authored-by: Ivana Kellyerova <ivana.kellyerova@sentry.io>
Co-authored-by: Ivana Kellyerova <ivana.kellyerova@sentry.io>
Co-authored-by: Ivana Kellyerova <ivana.kellyerova@sentry.io>
Co-authored-by: Ivana Kellyerova <ivana.kellyerova@sentry.io>
Co-authored-by: Ivana Kellyerova <ivana.kellyerova@sentry.io>
Co-authored-by: Ivana Kellyerova <ivana.kellyerova@sentry.io>
Co-authored-by: Ivana Kellyerova <ivana.kellyerova@sentry.io>
antonpirker
enabled auto-merge (squash)
September 7, 2023 15:05
Contributor
Author
|
Thanks for the fixes! Yes, at some point our lib will be a really well documented thing! |
…etsentry/sentry-python into antonpirker/cleanup-spans-transactions
sentrivana
added a commit
that referenced
this pull request
Sep 18, 2023
Added some docstrings and also did some minor cleanup for better readability of the code. --------- Co-authored-by: Ivana Kellyerova <ivana.kellyerova@sentry.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added some docstrings and also did some minor cleanup for better readability of the code.