Skip to content

Add option to specify client certificate #233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
maresac wants to merge 1 commit into from
Closed

Add option to specify client certificate #233

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions sentry_sdk/consts.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@
"debug": False,
"attach_stacktrace": False,
"ca_certs": None,
"cert_file": None,
}


Expand Down
4 changes: 3 additions & 1 deletion sentry_sdk/transport.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
from urllib import getproxies


def _make_pool(parsed_dsn, http_proxy, https_proxy, ca_certs):
def _make_pool(parsed_dsn, http_proxy, https_proxy, ca_certs, cert_file):
# Use http_proxy if scheme is https and https_proxy is not set
proxy = parsed_dsn.scheme == "https" and https_proxy or http_proxy
if not proxy:
Expand All @@ -28,6 +28,7 @@ def _make_pool(parsed_dsn, http_proxy, https_proxy, ca_certs):
"num_pools": 2,
"cert_reqs": "CERT_REQUIRED",
"ca_certs": ca_certs or certifi.where(),
"cert_file": cert_file,
}

if proxy:
Expand Down Expand Up @@ -95,6 +96,7 @@ def __init__(self, options):
http_proxy=options["http_proxy"],
https_proxy=options["https_proxy"],
ca_certs=options["ca_certs"],
cert_file=options["cert_file"],
)
self._disabled_until = None
self._retry = urllib3.util.Retry()
Expand Down