Skip to content

Add option to specify client certificate#233

Closed
maresac wants to merge 1 commit into
getsentry:masterfrom
maresac:feat/mutual-tls-support
Closed

Add option to specify client certificate#233
maresac wants to merge 1 commit into
getsentry:masterfrom
maresac:feat/mutual-tls-support

Conversation

@maresac

@maresac maresac commented Jan 10, 2019

Copy link
Copy Markdown

@codecov-io

This comment has been minimized.

@maresac

maresac commented Jan 11, 2019

Copy link
Copy Markdown
Author

Is there a possibility to re-run the pipeline without exceeding the API rate limit?

@untitaker

Copy link
Copy Markdown
Member

Sorry about that CI failure, will fix.

Did you manage to do something similar in Raven? We're a bit hesitant to support this as it's not a popular usecase and would prefer if you subclassed the HTTPTransport class yourself to provide this functionality.

Right now that class is not very flexible but I'll prepare another PR for that

@untitaker

Copy link
Copy Markdown
Member

Could you check if this fits your usecase? #235

@ckoehn

ckoehn commented Jan 11, 2019

Copy link
Copy Markdown

This will definitely work, but still sad that you don't want to support a feature which can be implemented by just adding 4 lines of code.

@untitaker

Copy link
Copy Markdown
Member

@ckoehn The reason I want to avoid having more options on the client is that we try to align those across SDKs. There are many options on urllib3.PoolManager that might be useful to some people (connection timeouts?), but adding individual support for each of them ends up being a lot of code.

Using a client certificate to authenticate the SDK against the server is very non-standard. The "auth" mechanism we intended for people to use was the key in the DSN. Let's say somebody added something to their nginx/apache cfg to check for HTTP Basic auth header. Would you expect me to merge the PR that adds corresponding username/password options to the SDK?

@untitaker untitaker closed this Jan 11, 2019
@ckoehn

ckoehn commented Jan 11, 2019

Copy link
Copy Markdown

Fair point. You didn't mention that you want to align the options across SDKs and I was just curious why you rejected such a simple change 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants