Add option to specify client certificate#233
Conversation
This comment has been minimized.
This comment has been minimized.
|
Is there a possibility to re-run the pipeline without exceeding the API rate limit? |
|
Sorry about that CI failure, will fix. Did you manage to do something similar in Raven? We're a bit hesitant to support this as it's not a popular usecase and would prefer if you subclassed the Right now that class is not very flexible but I'll prepare another PR for that |
|
Could you check if this fits your usecase? #235 |
|
This will definitely work, but still sad that you don't want to support a feature which can be implemented by just adding 4 lines of code. |
|
@ckoehn The reason I want to avoid having more options on the client is that we try to align those across SDKs. There are many options on Using a client certificate to authenticate the SDK against the server is very non-standard. The "auth" mechanism we intended for people to use was the key in the DSN. Let's say somebody added something to their nginx/apache cfg to check for HTTP Basic auth header. Would you expect me to merge the PR that adds corresponding username/password options to the SDK? |
|
Fair point. You didn't mention that you want to align the options across SDKs and I was just curious why you rejected such a simple change 😉 |
See urllib3 docs