Set response status code in transaction "response" context.#2312
Merged
Conversation
antonpirker
force-pushed
the
antonpirker/2289-response-status-code
branch
from
August 28, 2023 15:04
9ad3478 to
0ee7172
Compare
…alls ASGI3 (on a ASGI2 detected middleware)
antonpirker
marked this pull request as ready for review
August 29, 2023 10:59
sentrivana
approved these changes
Aug 29, 2023
sentrivana
left a comment
sentrivana
left a comment
Contributor
There was a problem hiding this comment.
Nicely done working around the asgi 2/3 differences! Left some nits to consider but LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make sure that the HTTP response status code be set in the transactions "response" context.
This works in WSGI (was already calling
set_http_status.) Also added this to ASGI projects.Fixes #2289