Skip to content

Adds DB connection attributes in spans#2274

Merged
sentrivana merged 27 commits into
masterfrom
antonpirker/2270-db-connection-attributes-in-spans
Jul 28, 2023
Merged

Adds DB connection attributes in spans#2274
sentrivana merged 27 commits into
masterfrom
antonpirker/2270-db-connection-attributes-in-spans

Conversation

@antonpirker

@antonpirker antonpirker commented Jul 27, 2023

Copy link
Copy Markdown
Contributor

Fixes #2270

@antonpirker
antonpirker marked this pull request as ready for review July 28, 2023 07:20
sentrivana
sentrivana requested changes Jul 28, 2023
View reviewed changes

@sentrivana sentrivana left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! The Django part might need some special casing for the different backends and one or two test cases for Django would also be great.

Comment thread sentry_sdk/integrations/django/__init__.py Outdated
Comment thread sentry_sdk/integrations/django/__init__.py Outdated
@antonpirker

antonpirker commented Jul 28, 2023

Copy link
Copy Markdown
Contributor Author

I updated the code to omit data fields that we can not fill. (asked joris about what they like more)

@antonpirker

antonpirker commented Jul 28, 2023

Copy link
Copy Markdown
Contributor Author

The chalice deps thing is still not fixed (something has deps to boto3 that are not working with our deps and I have not yet figured out what lib...)

@antonpirker

antonpirker commented Jul 28, 2023

Copy link
Copy Markdown
Contributor Author

Also Django tests for new db attributes are still missing.

@antonpirker

antonpirker commented Jul 28, 2023

Copy link
Copy Markdown
Contributor Author

Maybe I have some time in the afternoon to have another shot at this, but if not it would be great if you could take over @sentrivana . Sorry for not having everything ready..

@sentrivana

sentrivana commented Jul 28, 2023

Copy link
Copy Markdown
Contributor

Maybe I have some time in the afternoon to have another shot at this, but if not it would be great if you could take over @sentrivana . Sorry for not having everything ready..

No worries, I can take over. You should enjoy your vacation. :)

@sentrivana sentrivana mentioned this pull request Jul 28, 2023
Merged
@sentrivana
sentrivana merged commit d48d3eb into master Jul 28, 2023
@sentrivana
sentrivana deleted the antonpirker/2270-db-connection-attributes-in-spans branch July 28, 2023 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sentrivana sentrivana sentrivana approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add db connection attributes to database span's span data

2 participants

@antonpirker @sentrivana