fix: Push scope for each response chunk#218
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #218 +/- ##
==========================================
- Coverage 80.63% 80.09% -0.55%
==========================================
Files 31 31
Lines 2608 2592 -16
Branches 442 439 -3
==========================================
- Hits 2103 2076 -27
- Misses 327 329 +2
- Partials 178 187 +9
Continue to review full report at Codecov.
|
Closed
mitsuhiko
approved these changes
Dec 19, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will make WSGI apps more tolerant against:
start_responseclosenot being calledI have no idea or opinion about performance impact but I don't think it's much?