Wrap parse_url calls in capture_internal_exceptions#2162
Merged
Conversation
sentrivana
commented
Jun 9, 2023
sentrivana
marked this pull request as ready for review
June 9, 2023 10:24
antonpirker
approved these changes
Jun 13, 2023
antonpirker
left a comment
antonpirker
left a comment
Contributor
There was a problem hiding this comment.
Fine to merge if we use SENSITIVE_DATA_SUBSTITUTE as placeholder. But it is up to you, if you think thats a stupid idea also fine to merge right away.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to #2160
Our URL parsing and sanitizing can fail. If it does, the error must never break the user's application.
This PR:
parse_urlincapture_internal_exceptionsand skips setting any parsed URL related data on the span (affects thestdlib,boto3,httpxintegrations)sanitize_urlfunction withsplit=True