Handle sqlalchemy engine.name being bytes#2074
Merged
Merged
Conversation
sentrivana
force-pushed
the
ivana/pyhive-typeerror
branch
from
May 4, 2023 08:29
7913a82 to
eccd9d8
Compare
sentrivana
force-pushed
the
ivana/pyhive-typeerror
branch
from
May 4, 2023 08:57
eccd9d8 to
3556997
Compare
antonpirker
approved these changes
May 4, 2023
pedrorivotti
reviewed
May 4, 2023
| @@ -111,6 +112,8 @@ def _handle_error(context, *args): | |||
| # See: https://docs.sqlalchemy.org/en/20/dialects/index.html | |||
| def _get_db_system(name): | |||
| # type: (str) -> Optional[str] | |||
There was a problem hiding this comment.
type: (str) is no longer necessarily accurate.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are cases where
engine.namein sqlalchemy is not a string (see #2071).Fixes #2071