feat: Use http.method instead of method#2054
Merged
Merged
Conversation
AbhiPrasad
force-pushed
the
abhi-http-span-method
branch
from
April 28, 2023 13:07
5f3950f to
def613f
Compare
AbhiPrasad
marked this pull request as ready for review
April 28, 2023 13:07
Contributor
Author
|
@antonpirker this is now ready to review! |
antonpirker
approved these changes
May 4, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Blocked on #2053 merging, so draft for now.As per https://develop.sentry.dev/sdk/performance/span-data-conventions/, we want to rename
methodbeing set on spans tohttp.method. This better aligns with otel, and also removes ambiguity when operating in Relay.