Repository navigation
chore(profiling): Remove profile context from sdk - #2013
Merged
Merged
Conversation
The profile context can be populated by the relay automatically. No need to do this in the SDK. This also means that if the profile has to be dropped by relay due to rate limits or any reason, we won't render a bad link on the transaction to a non-existent profile.
Zylphrex
enabled auto-merge (squash)
April 17, 2023 14:00
xlurio
pushed a commit
to xlurio/sentry-python
that referenced
this pull request
Apr 18, 2023
The profile context can be populated by the relay automatically. No need to do this in the SDK. This also means that if the profile has to be dropped by relay due to rate limits or any reason, we won't render a bad link on the transaction to a non-existent profile.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The profile context can be populated by the relay automatically. No need to do this in the SDK. This also means that if the profile has to be dropped by relay due to rate limits or any reason, we won't render a bad link on the transaction to a non-existent profile.