test: Fix using unittest.mock whenever available#1926
Conversation
Fix some of the newly-added `mock` imports to prefer `unittest.mock` when it is available. Update `test-requirements.txt` to install `mock` only in Python < 3.3; hopefully this will suffice for CI to catch these regressions in the future.
|
This pull request has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you label it "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
|
This pull request has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you label it "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
|
This pull request has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you label it "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
|
@antonpirker, ping! |
|
This pull request has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you label it "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
|
updated the branch and restarted the tests |
|
Thanks @mgorny! |
|
Thanks! |
3 participants
Fix some of the newly-added
mockimports to preferunittest.mockwhen it is available. Updatetest-requirements.txtto installmockonly in Python < 3.3; hopefully this will suffice for CI to catch these regressions in the future.