Adds trace_propagation_targets option#1916
Merged
Merged
Conversation
antonpirker
changed the title
trace_propagation_targets option
antonpirker
changed the base branch from
master
to
antonppirker/update-httpx-testing
February 21, 2023 13:44
…5_trace_propagation_targets
…om:getsentry/sentry-python into antonpirker/1785_trace_propagation_targets
antonpirker
marked this pull request as ready for review
February 21, 2023 14:29
sl0thentr0py
requested changes
Feb 21, 2023
untitaker
reviewed
Feb 21, 2023
sl0thentr0py
requested changes
Feb 21, 2023
Member
|
Semantics for this option are defined here https://docs.sentry.io/platforms/node/guides/serverless-cloud/configuration/options/#trace-propagation-targets |
Contributor
Author
|
Now I changed the behavior to have a Matching is also done by substring like described in the linked develop docs. |
sl0thentr0py
requested changes
Feb 22, 2023
untitaker
reviewed
Feb 22, 2023
…om:getsentry/sentry-python into antonpirker/1785_trace_propagation_targets
Contributor
Author
|
I have now implemented @sl0thentr0py suggestion to fetch the options in the function. Now calling the function looks nicer. |
…om:getsentry/sentry-python into antonpirker/1785_trace_propagation_targets
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add an option
trace_propagation_targetsthat defines to what targets the trace headers (sentry-trace and baggage) are added in outgoing HTTP requests.Spec is here: https://docs.sentry.io/platforms/node/guides/serverless-cloud/configuration/options/#trace-propagation-targets
Fixes #1785