feat(cloud): Adding Cloud Resource Context#1882
Merged
Merged
Conversation
antonpirker
changed the title
antonpirker
marked this pull request as ready for review
February 8, 2023 12:44
…n of what it can contain.
antonpirker
changed the title
antonpirker
changed the title
sl0thentr0py
previously requested changes
Feb 10, 2023
sl0thentr0py
left a comment
sl0thentr0py
left a comment
Member
There was a problem hiding this comment.
a fundamental question first, review will come after we've discussed that
…/sentry-python into antonpirker/1820-cloud-context
This reverts commit 37586c5.
Contributor
Author
|
This is the cloud context definition in relay: getsentry/relay#1854 |
…/sentry-python into antonpirker/1820-cloud-context
antonpirker
dismissed
sl0thentr0py’s stale review
February 27, 2023 08:38
resolved discussion in slack.
HazAT
approved these changes
Feb 27, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1820
This is the cloud context definition in relay: getsentry/relay#1854