Skip to content

Fix check for Starlette in FastAPI integration #1868

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
antonpirker merged 3 commits into from
Jan 30, 2023
Merged

Fix check for Starlette in FastAPI integration #1868

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5758862
Fix check for Starlette in FastAPI integration
antonpirker Jan 27, 2023
f643023
Merge branch 'master' into antonpirker/1603-cannot-import-startlettei…
antonpirker Jan 30, 2023
f8d177f
Merge branch 'master' into antonpirker/1603-cannot-import-startlettei…
antonpirker Jan 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions sentry_sdk/integrations/fastapi.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,18 +3,21 @@
from sentry_sdk._types import MYPY
from sentry_sdk.hub import Hub, _should_send_default_pii
from sentry_sdk.integrations import DidNotEnable
from sentry_sdk.integrations.starlette import (
StarletteIntegration,
StarletteRequestExtractor,
)
from sentry_sdk.tracing import SOURCE_FOR_STYLE, TRANSACTION_SOURCE_ROUTE
from sentry_sdk.utils import transaction_from_function

if MYPY:
from typing import Any, Callable, Dict

from sentry_sdk.scope import Scope

try:
from sentry_sdk.integrations.starlette import (
StarletteIntegration,
StarletteRequestExtractor,
)
except DidNotEnable:
raise DidNotEnable("Starlette is not installed")

try:
import fastapi # type: ignore
except ImportError:
Expand Down