Fix check for Starlette in FastAPI integration#1868
Merged
antonpirker merged 3 commits intoJan 30, 2023
Conversation
antonpirker
requested review from
sl0thentr0py
and removed request for
sl0thentr0py
January 30, 2023 08:37
sl0thentr0py
approved these changes
Jan 30, 2023
antonpirker
deleted the
antonpirker/1603-cannot-import-startletteintegration
branch
January 30, 2023 14:21
|
Hi @antonpirker, I'm still seeing this issue on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When loading FastAPI integration also check if
StarletteIntegrationcan actually be loaded. (Because Starlette is a requirement for FastAPI)Fixes #1603