ref: upgrade linters to flake8 5.x#1610
Merged
Merged
Conversation
asottile-sentry
force-pushed
the
asottile-flake8-5
branch
from
September 12, 2022 16:35
8b0b539 to
d493950
Compare
asottile-sentry
commented
Sep 12, 2022
| @@ -1,16 +1,17 @@ | |||
| [flake8] | |||
| ignore = | |||
Contributor
Author
There was a problem hiding this comment.
extend-ignore is better than ignore, it preserves the default ignore
| E501, // Handled by black (Line too long) | ||
| W503, // Handled by black (Line break occured before a binary operator) | ||
| E402, // Sometimes not possible due to execution order (Module level import is not at top of file) | ||
| E731, // I don't care (Do not assign a lambda expression, use a def) |
Contributor
Author
There was a problem hiding this comment.
ini comments are either # or ; not // -- these are actually being interpreted as ignore codes https://flake8.pycqa.org/en/latest/user/configuration.html
| N812, // I don't care (Lowercase imported as non-lowercase by pep8-naming) | ||
| N804 // is a worse version of and conflicts with B902 (first argument of a classmethod should be named cls) | ||
| max-line-length = 80 | ||
| select = N,B,C,E,F,W,T4,B9 |
Contributor
Author
There was a problem hiding this comment.
this isn't necessary -- flake8 enables the codes of all extension by default
| N804 // is a worse version of and conflicts with B902 (first argument of a classmethod should be named cls) | ||
| max-line-length = 80 | ||
| select = N,B,C,E,F,W,T4,B9 | ||
| exclude=checkouts,lol*,.tox |
Contributor
Author
There was a problem hiding this comment.
extend-exclude is better as it preserves the default exclude list
asottile-sentry
marked this pull request as ready for review
September 12, 2022 16:59
asottile-sentry
commented
Sep 12, 2022
asottile-sentry
force-pushed
the
asottile-flake8-5
branch
from
September 13, 2022 14:55
d493950 to
1eb48d1
Compare
asottile-sentry
enabled auto-merge (squash)
September 14, 2022 00:02
asottile-sentry
force-pushed
the
asottile-flake8-5
branch
from
September 19, 2022 14:18
1eb48d1 to
74e0932
Compare
Contributor
|
Thanks for this update @asottile-sentry ! |
This was referenced Sep 20, 2022
antonpirker
approved these changes
Sep 20, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
noqa removal was automated via yesqa