Skip to content

Include LICENSE in sdist and clarify in README#158

Merged
untitaker merged 2 commits into
getsentry:masterfrom
mcs07:license
Oct 30, 2018
Merged

Include LICENSE in sdist and clarify in README#158
untitaker merged 2 commits into
getsentry:masterfrom
mcs07:license

Conversation

@mcs07

@mcs07 mcs07 commented Oct 30, 2018

Copy link
Copy Markdown
Contributor
  • Used a MANIFEST.in file to include the LICENSE file in PyPI sdist, as required by the BSD license.
  • Corrected README to say BSD not MIT, so it matches the LICENSE file and setup.py.

@codecov-io

codecov-io commented Oct 30, 2018

Copy link
Copy Markdown

Codecov Report

Merging #158 into master will increase coverage by 7.41%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #158      +/-   ##
==========================================
+ Coverage   67.57%   74.98%   +7.41%     
==========================================
  Files          28       28              
  Lines        2751     2323     -428     
  Branches      392      392              
==========================================
- Hits         1859     1742     -117     
+ Misses        740      433     -307     
+ Partials      152      148       -4
Impacted Files Coverage Δ
sentry_sdk/integrations/sanic.py 0% <0%> (-76.67%) ⬇️
sentry_sdk/integrations/aws_lambda.py 0% <0%> (-12.83%) ⬇️
sentry_sdk/_compat.py 84% <0%> (+3.23%) ⬆️
sentry_sdk/hub.py 79.67% <0%> (+4.02%) ⬆️
sentry_sdk/worker.py 87.34% <0%> (+4.2%) ⬆️
sentry_sdk/integrations/flask.py 75.49% <0%> (+4.84%) ⬆️
sentry_sdk/integrations/excepthook.py 86.36% <0%> (+6.36%) ⬆️
sentry_sdk/integrations/django/__init__.py 79.5% <0%> (+7.83%) ⬆️
sentry_sdk/scope.py 75% <0%> (+8.05%) ⬆️
sentry_sdk/integrations/rq.py 78% <0%> (+9.03%) ⬆️
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1128386...7f9c765. Read the comment docs.

@untitaker

Copy link
Copy Markdown
Member

thanks, I will merge as soon as the build is green

@untitaker
untitaker merged commit 5b15aaa into getsentry:master Oct 30, 2018
@untitaker

Copy link
Copy Markdown
Member

@mcs07 do you need a new release for this?

@mcs07

mcs07 commented Oct 30, 2018

Copy link
Copy Markdown
Contributor Author

No it's not urgently needed, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants