feat(profiling): Support for multithreaded profiles#1570
Merged
Conversation
Zylphrex
force-pushed
the
txiao/feat/support-for-multithreaded-profiles
branch
from
August 18, 2022 20:32
1de27f6 to
f5b789f
Compare
A signal handler can only be installed on the main thread, this was the reason why we could not use signals to profile multithreaded programs. This change installs the signal handler during sdk initialization which should happen on the main thread. The timers are still started on the individual threads to allow for profiles being recorded from different threads.
Zylphrex
force-pushed
the
txiao/feat/support-for-multithreaded-profiles
branch
from
August 18, 2022 20:44
f5b789f to
0aec42b
Compare
Zylphrex
marked this pull request as ready for review
August 18, 2022 20:45
sl0thentr0py
approved these changes
Sep 5, 2022
Member
There was a problem hiding this comment.
thx a lot @Zylphrex, this is so much cleaner now!
Just one question because I could not follow the logic there, but otherwise lgtm.
Can you also rebase master and resolve the conflict? Then we can 
.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A signal handler can only be installed on the main thread, this was the reason
why we could not use signals to profile multithreaded programs. This change
installs the signal handler during sdk initialization which should happen on the
main thread. The timers are still started on the individual threads to allow for
profiles being recorded from different threads.