feat(redis): Add instrumentation for redis pipeline#1543
Merged
Conversation
beezz
reviewed
Aug 5, 2022
untitaker
reviewed
Aug 5, 2022
untitaker
left a comment
untitaker
left a comment
Member
There was a problem hiding this comment.
leaving final review and approval to sdk folks, just some comments
|
|
||
| def _parse_redis_command(command): | ||
| # type: (Any) -> str | ||
| return " ".join(map(str, command[0])) |
Member
There was a problem hiding this comment.
i would align this with the code at the bottom of this file. there we use repr instead of str and no list comprehension/slicing. Perhaps you find a way to factor this out.
Member
Author
There was a problem hiding this comment.
Done. I factored out the constant.
jjbayer
commented
Aug 8, 2022
|
|
||
| def _parse_redis_command(command): | ||
| # type: (Any) -> str | ||
| return " ".join(map(str, command[0])) |
Member
Author
There was a problem hiding this comment.
Done. I factored out the constant.
sl0thentr0py
left a comment
sl0thentr0py
left a comment
Member
There was a problem hiding this comment.
thx @jjbayer cool stuff!
just a question / nit about the Strict.. renaming mess
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add automatic instrumentation of redis pipelining for both
redisandrediscluster.Note: This does not add instrumentation for
StrictRedisCluster.