Skip to content

Fixed problem with broken response #1516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
antonpirker merged 5 commits into from
Jul 22, 2022
Merged

Fixed problem with broken response #1516

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
41c3dcc
Fixed problem with broken response
antonpirker Jul 22, 2022
f630eaa
Same fix for fastapi
antonpirker Jul 22, 2022
68eb2ee
Fix problem when python-multipart is not installed
antonpirker Jul 22, 2022
5c6c2e4
Refactoring to make it like in other places in the sdk
antonpirker Jul 22, 2022
c4f52f5
Refactoring
antonpirker Jul 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions sentry_sdk/integrations/fastapi.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,7 @@ async def __call__(self, scope, receive, send):
hub = Hub.current
integration = hub.get_integration(FastApiIntegration)
if integration is None:
await self.app(scope, receive, send)
return

with hub.configure_scope() as sentry_scope:
Expand Down
11 changes: 10 additions & 1 deletion sentry_sdk/integrations/starlette.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
from __future__ import absolute_import


from sentry_sdk._compat import iteritems
from sentry_sdk._types import MYPY
from sentry_sdk.hub import Hub, _should_send_default_pii
Expand Down Expand Up @@ -41,6 +40,12 @@
# Startlette 0.19.1
from starlette.exceptions import ExceptionMiddleware # type: ignore

try:
# Optional dependency of Starlette to parse form data.
import multipart # type: ignore # noqa: F401
except ImportError:
multipart = None


_DEFAULT_TRANSACTION_NAME = "generic Starlette request"

Expand Down Expand Up @@ -339,6 +344,9 @@ async def form(self):
curl -X POST http://localhost:8000/upload/somethign -H "Content-Type: application/x-www-form-urlencoded" -d "username=kevin&password=welcome123"
curl -X POST http://localhost:8000/upload/somethign -F username=Julian -F password=hello123
"""
if multipart is None:
return None

return await self.request.form()

def is_json(self):
Expand Down Expand Up @@ -423,6 +431,7 @@ async def __call__(self, scope, receive, send):
hub = Hub.current
integration = hub.get_integration(StarletteIntegration)
if integration is None:
await self.app(scope, receive, send)
Copy link
Copy Markdown

@axyjo axyjo Jul 22, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this -- v1.8.0 is ~unusable with POST requests Starlette without this change

return

with hub.configure_scope() as sentry_scope:
Expand Down