Merged
Conversation
|
|
||
|
|
||
| def test_safe_repr_regressions(): | ||
| # fmt: off |
Contributor
Author
There was a problem hiding this comment.
So that black does not remove the u"" from the strings and breaks our tests.
Contributor
Author
There was a problem hiding this comment.
You can "turn off" black formatting for parts of the code.
Member
There was a problem hiding this comment.
no but why did you remove most of the other u""'s but not these ones?
Contributor
Author
There was a problem hiding this comment.
strings containing only ascii characters do not need u"" in python 2.7. Only strings containing unicode chars need the u"". (hence "u")
I think Python (2) did a really bad job in adding unicode support to the language
sl0thentr0py
approved these changes
Apr 1, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
.. and reformat code with new black.