Skip to content

Update error verbose for sentry init #1361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sl0thentr0py merged 11 commits into from
Apr 26, 2022
Merged

Update error verbose for sentry init #1361

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
21486d7
ref: Update error verbose for sentry init
tsingh-Q3 Mar 5, 2022
63169cc
Merge branch 'master' into update-sentry-init-error-verbose
targhs Mar 27, 2022
d81799e
Merge branch 'master' into update-sentry-init-error-verbose
antonpirker Mar 28, 2022
be97193
Merge branch 'master' into update-sentry-init-error-verbose
targhs Mar 29, 2022
b25e31a
Merge branch 'master' into update-sentry-init-error-verbose
targhs Apr 7, 2022
7076932
Merge branch 'master' into update-sentry-init-error-verbose
targhs Apr 11, 2022
d14a2e4
Merge branch 'master' into update-sentry-init-error-verbose
targhs Apr 12, 2022
07c4060
Merge branch 'master' into update-sentry-init-error-verbose
targhs Apr 12, 2022
2a6e6c1
Merge branch 'master' into update-sentry-init-error-verbose
targhs Apr 15, 2022
8d047f2
Merge branch 'master' into update-sentry-init-error-verbose
targhs Apr 17, 2022
b6e9089
Merge branch 'master' into update-sentry-init-error-verbose
targhs Apr 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions sentry_sdk/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,9 @@ def _get_options(*args, **kwargs):
else:
dsn = None

if len(args) > 1:
raise TypeError("Only single positional argument is expected")

rv = dict(DEFAULT_OPTIONS)
options = dict(*args, **kwargs)
if dsn is not None and options.get("dsn") is None:
Expand Down
6 changes: 6 additions & 0 deletions tests/test_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -887,3 +887,9 @@ def test_max_breadcrumbs_option(
capture_message("dogs are great")

assert len(events[0]["breadcrumbs"]["values"]) == expected_breadcrumbs


def test_multiple_positional_args(sentry_init):
with pytest.raises(TypeError) as exinfo:
sentry_init(1, None)
assert "Only single positional argument is expected" in str(exinfo.value)