Skip to content

Added default value for auto_session_tracking ... #1337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
antonpirker merged 4 commits into from
Feb 16, 2022
Merged

Added default value for auto_session_tracking ... #1337

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
280feb8
fix(asgi): Added default value for auto_session_tracking to make it w…
antonpirker Feb 14, 2022
b5895a2
Always return a boolean
antonpirker Feb 15, 2022
75f56a5
Fixed type anotations
antonpirker Feb 16, 2022
5f492e5
Merge branch 'master' into antonpirker/GH-1334-keyerror-auto-session-…
antonpirker Feb 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions sentry_sdk/sessions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,23 +10,27 @@
from sentry_sdk.utils import format_timestamp

if MYPY:
from typing import Callable
from typing import Optional
from typing import Any
from typing import Callable
from typing import Dict
from typing import List
from typing import Generator
from typing import List
from typing import Optional
from typing import Union


def is_auto_session_tracking_enabled(hub=None):
# type: (Optional[sentry_sdk.Hub]) -> bool
# type: (Optional[sentry_sdk.Hub]) -> Union[Any, bool, None]

@wbolster wbolster Feb 21, 2022

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you sure this shouldn't have stayed bool?

perhaps a return bool(should_track) can avoid mypy errors

"""Utility function to find out if session tracking is enabled."""
if hub is None:
hub = sentry_sdk.Hub.current

should_track = hub.scope._force_auto_session_tracking

if should_track is None:
client_options = hub.client.options if hub.client else {}
should_track = client_options["auto_session_tracking"]
should_track = client_options.get("auto_session_tracking", False)

return should_track


Expand Down