Added default value for auto_session_tracking ...#1337
Merged
antonpirker merged 4 commits intoFeb 16, 2022
Conversation
…ork in fastapi refs #1334
sl0thentr0py
approved these changes
Feb 14, 2022
|
Was hitting this using |
antonpirker
deleted the
antonpirker/GH-1334-keyerror-auto-session-tracking
branch
February 16, 2022 15:08
|
Following up here. Is there a plan to get this change backported or released in the near future? |
wbolster
reviewed
Feb 21, 2022
|
|
||
| def is_auto_session_tracking_enabled(hub=None): | ||
| # type: (Optional[sentry_sdk.Hub]) -> bool | ||
| # type: (Optional[sentry_sdk.Hub]) -> Union[Any, bool, None] |
There was a problem hiding this comment.
you sure this shouldn't have stayed bool?
perhaps a return bool(should_track) can avoid mypy errors
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… to make it work in fastapi
refs #1334