fix(django): Attempt custom urlconf resolve in got_request_exception as well#1317
Merged
sl0thentr0py merged 2 commits intomasterfrom Jan 24, 2022
Merged
fix(django): Attempt custom urlconf resolve in got_request_exception as well#1317sl0thentr0py merged 2 commits intomasterfrom
sl0thentr0py merged 2 commits intomasterfrom
Conversation
AbhiPrasad
approved these changes
Jan 24, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fix in #1308 only worked for transactions and not for exceptions since exceptions will nope out before
_after_get_reponseruns in most cases. This generalizes the solution to also run in_got_request_exception.https://getsentry.atlassian.net/browse/WEB-530