fix(python): Capture only 5xx HTTP errors in Falcon Integration#1314
Merged
antonpirker merged 13 commits intomasterfrom Jan 24, 2022
Merged
fix(python): Capture only 5xx HTTP errors in Falcon Integration#1314antonpirker merged 13 commits intomasterfrom
antonpirker merged 13 commits intomasterfrom
Conversation
…thub.com:getsentry/sentry-python into antonpirker/web-529/falcon-catch-all-http-errors
…thub.com:getsentry/sentry-python into antonpirker/web-529/falcon-catch-all-http-errors
antonpirker
requested review from
a team,
lobsterkatie and
sl0thentr0py
and removed request for
a team
rhcarvalho
reviewed
Jan 21, 2022
Contributor
rhcarvalho
left a comment
rhcarvalho
left a comment
There was a problem hiding this comment.
Very spot on, thanks for the clean, easy to review, patch @antonpirker!
I have one suggestion re: types, and one question about desired behavior.
rhcarvalho
reviewed
Jan 21, 2022
rhcarvalho
approved these changes
Jan 21, 2022
antonpirker
deleted the
antonpirker/web-529/falcon-catch-all-http-errors
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #753