Do not serialize mappings with custom __repr__ as dict-s#1300
Do not serialize mappings with custom __repr__ as dict-s#1300vmarkovtsev wants to merge 1 commit into
Conversation
|
@sl0thentr0py can you please review this 🙏 |
|
Hey @vmarkovtsev, thx for the contribution! |
780bee9 to
8032cee
Compare
|
I have fixed some tests and the style, but the CI does not trigger again. |
8032cee to
9621427
Compare
9621427 to
e1791a9
Compare
|
As I see, the only test that's failing is the serialization of |
|
@vmarkovtsev yes I think we want to preserve older behavior for classes such as The other option here is to give you a custom |
|
Yes, |
|
ok I'll make another PR then |
|
closing in favor of #1322 |
Fixes #1296