Fix "shutdown_timeout" typing by seedofjoy · Pull Request #1256 · getsentry/sentry-python

seedofjoy · 2021-11-16T17:31:36Z

Fix "shutdown_timeout" parameter typing

AbhiPrasad

Yup it seems like shutdown can be a float, thank you for your contribution!

Lines 404 to 419 in 5bd4775

    
                   timeout=None,  # type: Optional[float] 
        
                   callback=None,  # type: Optional[Callable[[int, float], None]] 
        
               ): 
        
                   # type: (...) -> None 
        
                   """ 
        
                   Wait for the current events to be sent. 
        
                   :param timeout: Wait for at most `timeout` seconds. If no `timeout` is provided, the `shutdown_timeout` option value is used. 
        
                   :param callback: Is invoked with the number of pending events and the configured timeout. 
        
                   """ 
        
                   if self.transport is not None: 
        
                       if timeout is None: 
        
                           timeout = self.options["shutdown_timeout"] 
        
                       self.session_flusher.flush() 
        
                       self.transport.flush(timeout=timeout, callback=callback)

Fix "shutdown_timeout" typing

16cd4f1

Fix "shutdown_timeout" parameter typing

AbhiPrasad approved these changes Nov 16, 2021

View reviewed changes

AbhiPrasad merged commit 40a309a into getsentry:master Nov 16, 2021

seedofjoy deleted the patch-1 branch November 17, 2021 08:49

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix "shutdown_timeout" typing#1256

Fix "shutdown_timeout" typing#1256
AbhiPrasad merged 1 commit into
getsentry:masterfrom
seedofjoy:patch-1

seedofjoy commented Nov 16, 2021

Uh oh!

AbhiPrasad left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

	timeout=None, # type: Optional[float]
	callback=None, # type: Optional[Callable[[int, float], None]]
	):
	# type: (...) -> None
	"""
	Wait for the current events to be sent.

	:param timeout: Wait for at most `timeout` seconds. If no `timeout` is provided, the `shutdown_timeout` option value is used.

	:param callback: Is invoked with the number of pending events and the configured timeout.
	"""
	if self.transport is not None:
	if timeout is None:
	timeout = self.options["shutdown_timeout"]
	self.session_flusher.flush()
	self.transport.flush(timeout=timeout, callback=callback)

Uh oh!

Conversation

seedofjoy commented Nov 16, 2021

Uh oh!

AbhiPrasad left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants