Add a Quart integration#1248
Conversation
AbhiPrasad
requested review from
a team,
lobsterkatie and
sl0thentr0py
and removed request for
a team
|
Awesome, thank you for your contribution! You might have to rebase because we fixed some broken tests on master. I think we'll need some tests if we want to get this merged, but more than happy to provide you with any assistance you need writing them. Once that's in a good place, we can also update the Sentry docs to link to this! |
sl0thentr0py
left a comment
sl0thentr0py
left a comment
There was a problem hiding this comment.
just one minor comment for now since @AbhiPrasad already reviewed
AbhiPrasad
left a comment
AbhiPrasad
left a comment
There was a problem hiding this comment.
Awesome looking great. Do you also mind also adding docs for quart in https://github.com/getsentry/sentry-docs/tree/master/src/platforms/python/guides? We can then mention the 0.16.1 version requirement, as well as what SDK version it's available in.
As an example, see what we do for Sanic: https://github.com/getsentry/sentry-docs/blob/master/src/platforms/python/guides/sanic/index.mdx
sentry_sdk/integrations/__init__.py
Outdated
| _AUTO_ENABLING_INTEGRATIONS = ( | ||
| "sentry_sdk.integrations.django.DjangoIntegration", | ||
| "sentry_sdk.integrations.flask.FlaskIntegration", | ||
| "sentry_sdk.integrations.quart.QuartIntegration", |
There was a problem hiding this comment.
Not sure we want Quart to be auto enabling quite yet, we can turn it on later based on user feedback. For now let's leave it off?
There was a problem hiding this comment.
Should I remove all the tests for the auto integration as well?
|
I've added documentation, getsentry/sentry-docs#4444. |
|
Thank @pgjones. We haven't had the time to look at this recently, but it's on our radar and we really want to see it merged! Will do another review soon, thanks for your patience :) |
|
I've disabled the auto integration as an additional commit, which will make it easier to revert when desired. |
This is based on the Flask integration but includes background and websocket exceptions, and works with asgi.
This can be reverted when the integration is considered stable.
|
Thanks a lot @pgjones for the contribution and for your patience! |
4 participants
This is based on the Flask integration but includes background and
websocket exceptions, and works with asgi.
Note I think the background task exception monitoring and Quart-Auth integration make this more useful than the ASGI middleware alone.
If this is welcomed I'm happy to write the tests (based on the Flask ones).