build(craft): Remove Python 2.7 support for AWS Lambda layers#1241
Merged
Conversation
iker-barriocanal
requested review from
rhcarvalho and
vladanpaunovic
and removed request for
a team
November 4, 2021 16:20
rhcarvalho
approved these changes
Nov 4, 2021
rhcarvalho
left a comment
rhcarvalho
left a comment
Contributor
There was a problem hiding this comment.
Solid 👍
Note that end of support Phase 2 is November 22nd, but if the timelines there are correct, since July one cannot create new functions with 2.7, but can change existing functions. I think we're safe.
https://docs.aws.amazon.com/lambda/latest/dg/runtime-support-policy.html
Also note that existing Python 2.7 lambdas will continue to run indefinitely. But IIUC one would not be able to change it to use a new lambda layer for Sentry.
https://aws.amazon.com/blogs/compute/announcing-end-of-support-for-python-2-7-in-aws-lambda/
Need to check the failed CI tests.
Contributor
Author
|
Good context. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From AWS docs:
Since Python 2.7 is no longer supported, there's no point in having it as a compatible runtime for the created layers. Removing this version means new layers created by Craft on releases won't have it as a compatible runtime; so it doesn't affect existing layers.