feat(aws-lambda): Add Python 3.9 support#1239
Merged
Merged
Conversation
tomscytale
commented
Nov 3, 2021
tomscytale
commented
Contributor
- Added AWS Lambda Python 3.9 runtime support
- Ignore mypy module check
- Fixed check bug and added python3.9 runtime to tests
- Revert comment
- run black on aws_lambda.py and test
- add python3.9 as compatible runtime in .craft.yml
tomscytale
changed the title
tomscytale
changed the title
AbhiPrasad
approved these changes
Nov 3, 2021
AbhiPrasad
left a comment
AbhiPrasad
left a comment
Contributor
There was a problem hiding this comment.
This LGTM, thanks for your contribution!
Contributor
Author
|
@AbhiPrasad thanks . What's with the test failures? They look spurious. |
Contributor
|
Yup they seem to be flaky tests for sanic, we’ll take care of that before merging in this PR. |
iker-barriocanal
changed the title
iker-barriocanal
approved these changes
Nov 15, 2021
iker-barriocanal
left a comment
iker-barriocanal
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Thanks for contributing, @tomscytale! I think we should fix master before merging this PR, what do you think @AbhiPrasad?
Contributor
|
Master should be fixed, please rebase. |
tomscytale
force-pushed
the
razumeiko/master
branch
from
November 16, 2021 15:04
2c688d0 to
34378a1
Compare
Contributor
Author
|
@AbhiPrasad done |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.