Skip to content

feat(tracing): Add user data/transaction name to tracestate value #1177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lobsterkatie merged 2 commits into from
Aug 30, 2021
Merged

feat(tracing): Add user data/transaction name to tracestate value #1177

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0919fd1
add transaction name to tracestate
lobsterkatie Aug 27, 2021
b2e7c4c
add user data to tracestate
lobsterkatie Aug 30, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 20 additions & 1 deletion sentry_sdk/tracing_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -309,17 +309,36 @@ def compute_tracestate_entry(span):
"""
data = {}

client = (span.hub or sentry_sdk.Hub.current).client
hub = span.hub or sentry_sdk.Hub.current

client = hub.client
scope = hub.scope

if client and client.options.get("dsn"):
options = client.options
user = scope._user

data = {
"trace_id": span.trace_id,
"environment": options["environment"],
"release": options.get("release"),
"public_key": Dsn(options["dsn"]).public_key,
}

if user and (user.get("id") or user.get("segment")):
user_data = {}

if user.get("id"):
user_data["id"] = user["id"]

if user.get("segment"):
user_data["segment"] = user["segment"]

data["user"] = user_data

if span.containing_transaction:
data["transaction"] = span.containing_transaction.name

return "sentry=" + compute_tracestate_value(data)

return None
Expand Down
4 changes: 4 additions & 0 deletions tests/tracing/test_http_headers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,8 @@ def test_tracestate_computation(sentry_init):
release="off.leash.park",
)

sentry_sdk.set_user({"id": 12312013, "segment": "bigs"})

transaction = Transaction(
name="/interactions/other-dogs/new-dog",
op="greeting.sniff",
Expand All @@ -46,6 +48,8 @@ def test_tracestate_computation(sentry_init):
"environment": "dogpark",
"release": "off.leash.park",
"public_key": "dogsarebadatkeepingsecrets",
"user": {"id": 12312013, "segment": "bigs"},
"transaction": "/interactions/other-dogs/new-dog",
}


Expand Down