Added AWS Lambda Python 3.9 runtime support#1174
Conversation
|
Hey @razumeiko |
|
@razumeiko Any plan to push forward this PR? |
|
I tried to use this PR code, but unhandled exceptions are not captured. |
|
I'll try to write tests in the next couple of days. @aahung can you clarify please what exceptions are you faced with? |
|
I was going to write some tests but when i run tests locally on clean repo i have weird errors 3.8 Runtime 3.7 Runtime E subprocess.CalledProcessError: Command '['pip', 'install', '--no-cache-dir', '-q', 'dist/sentry_sdk-1.3.1-py2.py3-none-any.whl', '-t', '/var/folders/yd/mnqmxwr9211bqxc60qtbvgzc0000gn/T/tmp4eb2v42d/python']' returned non-zero exit status 1. test_non_dict_event[python3.8-"Good dog!"-False-1] And so on. |
|
I added runtime 3.9 to tests and fixed a small bug in the code. I am not sure if tests will pass but let's try it. |
|
The runtime should also be added as a compatible runtime in the Craft config, see https://github.com/getsentry/sentry-python/blob/master/.craft.yml#L13. |
|
I attempted to open a pr against razumeiko:master to fix the lint issue, but accidentally created a new PR here - #1239 May as well leave it open - razumeiko doesn't appear to be active recently. |
|
Closing as #1239 was merged. |
AWS changed bootstrap location in Python 3.9 runtime.
Tested on next runtimes: 3.7, 3.8, 3.9
Issue: #1170