Skip to content

fix(mypy): Use correct typings for set_user #1167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AbhiPrasad merged 1 commit into from
Aug 20, 2021
Merged

fix(mypy): Use correct typings for set_user #1167

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sentry_sdk/api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,7 +171,7 @@ def set_extra(key, value):

@scopemethod # noqa
def set_user(value):
# type: (Dict[str, Any]) -> None
# type: (Optional[Dict[str, Any]]) -> None
return Hub.current.scope.set_user(value)


Expand Down
4 changes: 2 additions & 2 deletions sentry_sdk/scope.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,12 +185,12 @@ def transaction(self, value):

@_attr_setter
def user(self, value):
# type: (Dict[str, Any]) -> None
# type: (Optional[Dict[str, Any]]) -> None
"""When set a specific user is bound to the scope. Deprecated in favor of set_user."""
self.set_user(value)

def set_user(self, value):
# type: (Dict[str, Any]) -> None
# type: (Optional[Dict[str, Any]]) -> None
"""Sets a user for the scope."""
self._user = value
if self._session is not None:
Expand Down