feat(integration): Add support for Sanic >=21.3#1146
Merged
Conversation
untitaker
requested changes
Jul 7, 2021
AbhiPrasad
reviewed
Jul 7, 2021
rhcarvalho
removed their request for review
July 7, 2021 12:33
ahmedetefy
force-pushed
the
ahmed-sanic-integration-latest
branch
2 times, most recently
from
July 7, 2021 12:41
35a8ed9 to
7f9a482
Compare
ahmedetefy
force-pushed
the
ahmed-sanic-integration-latest
branch
from
July 7, 2021 12:42
7f9a482 to
d266c21
Compare
AbhiPrasad
reviewed
Jul 7, 2021
| sanic_app_name = self.ctx.app.name | ||
| scope.transaction = rv[0].name.split( | ||
| "%s." % sanic_app_name | ||
| )[1] |
Contributor
There was a problem hiding this comment.
Could the name.split list length ever be 0 or 1?
Contributor
Author
There was a problem hiding this comment.
Contributor
Author
There was a problem hiding this comment.
self.name cannot be null
Contributor
Author
There was a problem hiding this comment.
I will add safe guards regardless
ahmedetefy
force-pushed
the
ahmed-sanic-integration-latest
branch
from
July 7, 2021 13:45
e2ea2d1 to
c876801
Compare
AbhiPrasad
approved these changes
Jul 7, 2021
AbhiPrasad
left a comment
AbhiPrasad
left a comment
Contributor
There was a problem hiding this comment.
Let's ship to unblock users.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR:
Note/Todo:
Fixes: #1066, #1128